Test dartsass:install command
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am seeing test failures when running the GitHub CI workflow in my own fork, but only with Ruby 3.0 and Rails >= 7.1. I'm not sure what is happening, but it's something related to Bundler (the |
jonathanhefner
force-pushed
the
test-installer
branch
from
b423960
to
22bc2f7
Compare
jonathanhefner
commented
Dec 3, 2023
Comment on lines
+42
to
+48
| # This prevents a "Failed to build gem native extension" error when | ||
| # running `bundle install` inside a Rails app that is generated for | ||
| # testing. The error occurs only in CI, and only when using Ruby 3.0 and | ||
| # Rails >= 7.1. | ||
| - name: Install sass-embedded gem | ||
| if: ${{ matrix.ruby-version == '3.0' }} | ||
| run: gem install sass-embedded |
There was a problem hiding this comment.
The underlying cause is unclear, but this is the resolution to my previous comment.
This adds testing infrastructure to test against multiple versions of Rails, including Rails `main` branch.
jonathanhefner
force-pushed
the
test-installer
branch
from
22bc2f7
to
b7c781b
Compare
This adds test coverage for the `dartsass:install` command. The command is tested against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.
jonathanhefner
force-pushed
the
test-installer
branch
from
b7c781b
to
9c92c6f
Compare
|
@jonathanhefner did you get all the variations to pass? |
|
@dhh Yes: https://github.com/jonathanhefner/dartsass-rails/actions/runs/7089553301. I did not merge because I do not have commit permissions for this repo. 😄 |
This was referenced Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks large because this project currently has no testing infrastructure. The vast majority of LOC in this PR are from
GemfileandGemfile.lockfiles. I have split the PR into two commits to further clarify. The latter commit has the actual testing code, which amounts to ~70 lines of test code + ~70 lines of helper code.This adds test coverage for the
dartsass:installcommand. The command is tested against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.Infrastructure has been added to run tests against Rails 6.1, 7.0, 7.1, and
mainbranch, all with both Sprockets and Propshaft.